fix: fixes ring.SetAddrs and rebalance race #2283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on reducing
ring.SetAddrs
lock contention (see #2190 (comment)) I have discovered a race condition betweenSetAddrs
andrebalance
which I would like to fix first and separately.The change consists of two commits:
The fix ensures atomic update of
c.hash
andc.shards
, otherwisec.hash
may return shard name that is not in thec.shards
and cause ring operation panic.BenchmarkRingRebalanceLocked
shows rebalance latency if that is a concern:(Note: it essentially reverts a46b053)
Updates #2077
FYI @szuecs